surface (fix): Fix #3416 and #3419 - protected and package private access #3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndrejSpanel
force-pushed
the
fix-3416-protected
branch
from
0a5e11a
to
df52e6b
Compare
|
All tests added have already passed in Scala 2. After the fix they pass in Scala 3 as well. |
OndrejSpanel
changed the title
xerial
changed the title
This was
linked to
issues
Feb 28, 2024
|
@OndrejSpanel Thanks for the fix! I've applied scalafmtAll to fix the code format. Otherwise, it looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with tests - I hope I will be able to implement the fix as well.