Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore type message listener #59

Merged
merged 1 commit into from
Sep 25, 2023
Merged

restore type message listener #59

merged 1 commit into from
Sep 25, 2023

Conversation

gkatrakazas
Copy link
Contributor

I restored unregisterMessageListener type as it was causing problems with notifications. Additionally, it appeared that this type wasn't properly connected to the resolved error page.

@pstamatop
Copy link
Contributor

I can't find the pattern of the behavior but with this change I got the unregisterMessageListener is not a function error.
However, on this branch the fcm token is saved on the database.

@emlun
Copy link
Member

emlun commented Sep 22, 2023

I think there are some issues in handleServerMessagesGuard - it currently opens a new socket on each render, for example. Maybe that's the cause of some of the issues.

I experimented a bit with restructuring handleServerMessagesGuard to make better use of the React state model, but that seemed to just surface other issues instead. I'll push the branch so you can take a look at it, though.

@pstamatop pstamatop merged commit 81f18b8 into master Sep 25, 2023
0 of 2 checks passed
@emlun emlun deleted the fix-messagelistener branch September 25, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants