main: used lockedSection instead of explicit lock/unlock calls #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed setup.cfg to require python >= 3.7 and updated the build-system spec in pyproject.toml.
It's better to use a context manager for locks so that unlock calls are not missed. Basically we just put a locked section around the implementation of "main", but back out of it temporarily when we (maybe) fork the child process that runs the job. The parent then exits (lock not held), while the child process will regain the lock while it handles the rest of the options, finally releasing it before calling runJob. In runJob, again, when it terminates, it updates the database and so uses another lockedSection() call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's better to use a context manager for locks so that unlock calls are not missed.
Basically we just put a locked section around the implementation of "main", but back
out of it temporarily when we (maybe) fork the child process that runs the job. The
parent then exits (lock not held), while the child process will regain the lock while
it handles the rest of the options, finally releasing it before calling runJob.
In runJob, again, when it terminates, it updates the database and so uses another
lockedSection() call.