chat: add a timeout to requests.post call #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwade
force-pushed
the
timeout-requests.post
branch
from
67d03fc
to
24c29d9
Compare
The new pylint advises us that programs using requests.METHOD without a timeout can hang forever, which seems surprising given that they're using TCP connections, but even still, two hours is probably too long as well. Added a timeout to "chatmail" with a default value of 10 seconds.
wwade
force-pushed
the
timeout-requests.post
branch
from
24c29d9
to
cf39e09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new pylint advises us that programs using requests.METHOD without a timeout can
hang forever, which seems surprising given that they're using TCP connections, but
even still, two hours is probably too long as well.
Added a timeout to "chatmail" with a default value of 10 seconds.