mail: handle autoDecode failure for job logs with binary data #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a missing function name to indicate the log level. This one should be at the "debug" level since we tend to need to run the kill commands a few times to stick.
I ran a command that wrote a tarball into the job log file and so it couldn't be decoded as utf-8. It subsequently caused autoDecode to fail with a UnicodeDecodeError. ValueError is an ancestor of UnicodeDecodeError and would hopefully cover other decoding errors for other encodings as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran a command that wrote a tarball into the job log file and so it
couldn't be decoded as utf-8. It subsequently caused autoDecode to
fail with a UnicodeDecodeError.
ValueError is an ancestor of UnicodeDecodeError and would hopefully
cover other decoding errors for other encodings as well.