No more python 3.7, add python 3.11 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pipes` module is deprecated starting in python 3.11.
It seems that pylint has a submarine dependency on `wrapt` and starts to fail on python 3.11, so add it explicitly to the dev targets in the Pipfile.
If it's called "testEnv" then pytest tries to run it as a test, but then it gets confused as to why it's returning a value and issues a warning. We don't want to run it since it's just a test helper, so rename it.
wwade
force-pushed
the
py311
branch
3 times, most recently
from
231646f
to
e2f675e
Compare
There seems to be a problem with mock in python3.11 and mocking out socket.gethostname, so I just added a wrapper function inside the plugins module that I'm mocking instead.
Note: they expect (and require) that they're run from inside a virtualenv.
Typical:
pipenv run make all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.