This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Remove HY000 from database failure states: #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matt-blanchette
commented
Dec 31, 2013
matt-blanchette
commented
- Reverts changes in cc30c87
- HY000 is a very generic error that some databases or drivers will return it for any error that has no specific sql state, such as mysql
- the entire connection pool should not be killed when this code refers to benign errors
- mysql docs: Not all MySQL error numbers have corresponding SQLSTATE values. In these cases, 'HY000' (general error) is used.
- HY000 was originally added for firebird in 37b3b7c
* Reverts changes in cc30c87 * HY000 is a very generic error that some databases or drivers will return it for any error that has no specific sql state, such as mysql * the entire connection pool should not be killed when this code refers to benign errors * mysql docs: Not all MySQL error numbers have corresponding SQLSTATE values. In these cases, 'HY000' (general error) is used. * HY000 was originally added for firebird in 37b3b7c
|
This fixes bug # 1258339: |
|
But this may break the intended fix for bug # 753576: |
|
Thanks for fixing the issue I reported. Since I'm using playframework 2 I have nothing but problems with bonecp closed connections. |
|
by the way, the exception swallowing mentioned in https://bugs.launchpad.net/bonecp/+bug/1258339 is still not fixed by this |
wwadge
added a commit
that referenced
this pull request
Feb 7, 2014
Remove HY000 from database failure states:
|
Thanks! |
This was referenced May 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.