ded#160 Fix problem where no specificed content-type throws exceptions.

wwalser · Apr 14, 2015 · 1d62762 · 1d62762
1 parent b4171a0
commit 1d62762
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 1 deletion.
diff --git a/make/tests.js b/make/tests.js
@@ -27,6 +27,10 @@ var routes = {
         delayed.pipe(res)
       }, 2000)
   },
+  '/tests/204': function(req, res) {
+    res.writeHead(204);
+    res.end();
+  },
   '(([\\w\\-\\/\\.]+)\\.(css|js|json|jsonp|html|xml)$)': function (req, res, next, uri, file, ext) {
     res.writeHead(200, {
         'Expires': 0

diff --git a/reqwest.js b/reqwest.js
@@ -237,6 +237,7 @@
 
   function setType(header) {
     // json, javascript, text/plain, text/html, xml
+    if (header === null) return undefined; //In case of no content-type.
     if (header.match('json')) return 'json'
     if (header.match('javascript')) return 'js'
     if (header.match('text')) return 'html'

diff --git a/reqwest.min.js b/reqwest.min.js
diff --git a/src/reqwest.js b/src/reqwest.js
@@ -231,6 +231,7 @@
 
   function setType(header) {
     // json, javascript, text/plain, text/html, xml
+    if (header === null) return undefined; //In case of no content-type.
     if (header.match('json')) return 'json'
     if (header.match('javascript')) return 'js'
     if (header.match('text')) return 'html'

diff --git a/tests/tests.js b/tests/tests.js
@@ -801,6 +801,15 @@
       })
     })
 
+    test('standard mode on no content-type', function (complete) {
+      ajax({
+        url: '/tests/204'
+          , success: function (resp) {
+            ok(true, 'Nothing blew up.')
+          }
+        })
+    })
+
     test('compat mode "dataType=json" headers', function (complete) {
       ajax.compat({
           url: '/tests/none.json?echo'