Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w3 makes this gem compatible with sprockets-rails version 3 #2

Merged
merged 1 commit into from
Jan 27, 2016
Merged

Conversation

davidgross
Copy link

No description provided.

url(data:application/octet-stream;charset=utf-8;base64,<%= Base64.strict_encode64(Rails.application.assets['fontawesome-webfont.woff'].source) %>) format('woff'),
url(data:application/x-font-ttf;charset=utf-8;base64,<%= Base64.strict_encode64(Rails.application.assets['fontawesome-webfont.ttf'].source) %>) format('truetype'),
url(data:image/svg+xml;charset=utf-8;base64,<%= Base64.strict_encode64(Rails.application.assets['fontawesome-webfont.svg'].source) %>) format('svg');
src: url(data:application/octet-stream;charset=utf-8;base64,<%= Base64.strict_encode64(File.open(File.join(File.dirname(File.expand_path(__FILE__)), '/../fonts/fontawesome-webfont.eot'), 'rb').to_s) %>);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this change. When I try Rails.application.assets from a console it works fine. Is there an issue with it on deploy?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprockets-Rails v3 does not support that method when we have config.assets.compile = false

it works locally because in development.rb config.assets.compile = true.

see: rails/sprockets-rails#237 (comment)

@aaron aaron assigned davidgross and unassigned aaron Jan 27, 2016
@davidgross davidgross assigned aaron and unassigned davidgross Jan 27, 2016
aaron added a commit that referenced this pull request Jan 27, 2016
w3 makes this gem compatible with sprockets-rails version 3
@aaron aaron merged commit d349fdc into master Jan 27, 2016
@aaron aaron deleted the v3 branch January 27, 2016 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants