Fixes FreeCAD#14349: GeoFeature::getElementTypes causes undefined beh…

…aviour
wwmayer · May 30, 2024 · a4c9b66 · a4c9b66
1 parent d16df44
commit a4c9b66
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/App/GeoFeature.cpp b/src/App/GeoFeature.cpp
@@ -268,7 +268,7 @@ const std::vector<std::string>& GeoFeature::searchElementCache(const std::string
     return none;
 }
 
-const std::vector<const char*>& GeoFeature::getElementTypes(bool /*all*/) const
+std::vector<const char*> GeoFeature::getElementTypes(bool /*all*/) const
 {
     static std::vector<const char*> nil;
     auto prop = getPropertyOfGeometry();

diff --git a/src/App/GeoFeature.h b/src/App/GeoFeature.h
@@ -177,7 +177,7 @@ class AppExport GeoFeature : public App::DocumentObject
     virtual DocumentObject *getElementOwner(const Data::MappedName & /*name*/) const
     {return nullptr;}
 
-    virtual const std::vector<const char *>& getElementTypes(bool all=true) const;
+    virtual std::vector<const char *> getElementTypes(bool all=true) const;
 
     /// Return the higher level element names of the given element
     virtual std::vector<Data::IndexedName> getHigherElements(const char *name, bool silent=false) const;