Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhardcoded app launcher icon filetype #2

Merged
merged 1 commit into from Apr 13, 2017
Merged

Unhardcoded app launcher icon filetype #2

merged 1 commit into from Apr 13, 2017

Conversation

palob
Copy link
Contributor

@palob palob commented Apr 13, 2017

Since you're going to install the icon to a location compliant with freedesktop.org standards you don't need to specify the icon file extension in the .desktop launcher. It will be found anyway.

This facilitates the use of non-PNG (e.g. SVG) app icon themes.
Cf. this example .desktop launcher.

@wwmm wwmm merged commit 63d0365 into wwmm:master Apr 13, 2017
@wwmm
Copy link
Owner

wwmm commented Apr 13, 2017

Nice! I had no idea. I do not even know why it was hardcoded a png file extension when I am shipping a svg icon... This was the first time I ever merged a contribution. Until now I had always used git on my own. I hope everything have gone ok :)

@wwmm
Copy link
Owner

wwmm commented Apr 13, 2017

By the way it would be really nice to have a good icon. I really lack the imagination and the habilities necessaries for this task XD

@palob
Copy link
Contributor Author

palob commented Apr 13, 2017

Thanks, I'll note this and see if I can do icons some time :)

wwmm pushed a commit that referenced this pull request Nov 6, 2017
wwmm pushed a commit that referenced this pull request Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants