Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatpak extension path also for Convolver and RNNoise #3098

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

Digitalone1
Copy link
Contributor

@Digitalone1 Digitalone1 commented Apr 23, 2024

@vchernin This is related to this issue.

Please test it.

I wonder if it's better to use /app/extensions/easyeffects-presets. Maybe Presets is too generic? Could /app/extensions path be used also by other Flatpak apps?

Copy link

github-actions bot commented Apr 23, 2024

Workflow failed, but the following artifacts are still available for this pull request:

@wwmm wwmm merged commit c5a051c into wwmm:master Apr 23, 2024
8 of 10 checks passed
@vchernin
Copy link
Contributor

vchernin commented Apr 23, 2024

I wonder if it's better to use /app/extensions/easyeffects-presets. Maybe Presets is too generic? Could /app/extensions path be used also by other Flatpak apps?

The current /app/extensions/Presets should not be a problem. The reason these presets are able to install at extensions/Presets is because we have defined it here:

"directory": "extensions/Presets",

What other flatpak apps or extensions are doing cannot conflict with that directory without us modifying that file. For example the audio plugins are sometimes using extensions/Plugins but that is fine since they can only use that directory currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants