Tabs technical design NDS-187 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0ji
requested changes
Apr 18, 2022
accepted/0003-component-tabs.md
Outdated
|
|
||
| ### Tab | ||
|
|
||
| `<Tab>` extends the `React.ComponentPropsWithRef<'button'>` interface with `role="tab"`, `aria-selected="true/false"` and `aria-controls="tab-ID"` (an autogenerated unique prefix might be needed to support the case were there are multiple tab components rendered at the same time and share tab names) attributes. The values for `aria-selected` and `aria-controls` should be calculated using the state delivered by the `Tabs` wrapper |
There was a problem hiding this comment.
Implementation note: we probably want https://wwnorton.atlassian.net/browse/NDS-22 to be done before we finalize this since the autogenerated ids should be generated by that solution.
sh0ji
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
LGTM! Thanks for all your work on this.
I'm going to merge it but thought of one question that we can resolve during implementation: what should happen if the <TabList> or <TabPanels> containers aren't included? I assume they're required for styling.
For instance:
<Tabs>
<Tab>Cats</Tab>
<Tab>Dogs</Tab>
<Tab>Horses</Tab>
<TabPanel>Cats content</TabPanel>
<TabPanel>Dogs content</TabPanel>
<TabPanel>Horses content</TabPanel>
</Tabs>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatted file on https://github.com/wwnorton/design-system-rfcs/blob/tabs-juan/accepted/0003-component-tabs.md