closes wwosimulation/tracker/issues/583 #406
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendaonfire007
requested changes
Dec 9, 2022
| @@ -11,7 +11,7 @@ module.exports = { | |||
| const players = db.get(`players`) | |||
| let player = db.get(`player_${message.author.id}`) || { status: "Dead" } | |||
|
|
|||
| if (!message.channel.name.startsWith("priv")) return // if they are not in the private channel | |||
| if (!message.channel.parentId == "892046231516368906") return // if they are not in the private channel | |||
There was a problem hiding this comment.
magic number (or more like string but ya get what i mean)
There was a problem hiding this comment.
really important considering it repeats in so many locations
| @@ -19,7 +19,7 @@ module.exports = { | |||
| .replace(/@here/g, "here") | |||
| .replace(/<([@#])+[&]?[\d]{10,20}>/g, "[ping]") | |||
|
|
|||
| if (message.channel.name.startsWith("priv")) { | |||
| if (message.channel.parentId == "892046231516368906") { | |||
| if (!["Jailer", "Medium", "Ritualist", "Alpha Werewolf", "Sect Leader", "Instigator"].includes(player.role) && !["Jailer", "Medium", "Ritualist", "Alpha Werewolf", "Sect Leader", "Instigator"].includes(player.dreamRole)) return | |||
There was a problem hiding this comment.
honestly the if's one after another are suffocating each other NL plz?
| @@ -372,7 +375,7 @@ module.exports = { | |||
|
|
|||
| let guy = await interaction.guild.members.fetch(player) | |||
|
|
|||
| let channel = await interaction.guild.channels.create(`priv-${roleData.name.toLowerCase().replace(/\s/g, "-")}`, { | |||
| let channel = await interaction.guild.channels.create(index + 1 + "-" + guy.user.username, { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes wwosimulation/tracker/issues/583
closes wwosimulation/tracker/issues/580