Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StoryboardLoadable protocol doesn't work with AnyWorkflow.PassedArgs #80

Closed
Richard-Gist opened this issue Jul 26, 2021 · 0 comments · Fixed by #81
Closed

StoryboardLoadable protocol doesn't work with AnyWorkflow.PassedArgs #80

Richard-Gist opened this issue Jul 26, 2021 · 0 comments · Fixed by #81
Labels
bug Something isn't working
Projects
SwiftCurrent Kanban

Comments

@Richard-Gist
Copy link
Collaborator

Woah...there was a deep underlying issue with SwiftCurrent altogether here. Short version? When the input type was AnyWorkflow.PassedArgs it was not using the factory method. Meaning all the StoryboardLoadable protocol things simply don't work with AnyWorkflow.PassedArgs, you can discover this yourself if you simply don't use PassthroughFlowRepresentable.

I can try to fix that as part of this issue, but it feels like this'll get stuck on behalf of a bug that has nothing to do with this new feature for a while.

Originally posted by @Tyler-Keith-Thompson in #79 (comment)
@Richard-Gist Richard-Gist added the bug Something isn't working label Jul 26, 2021
@Richard-Gist Richard-Gist mentioned this issue Jul 26, 2021
Merged
7 tasks
@morganzellers morganzellers moved this from To Do to In progress (NaN) in SwiftCurrent Kanban Jul 27, 2021
@morganzellers morganzellers moved this from In progress (NaN) to Review in SwiftCurrent Kanban Jul 27, 2021
@Richard-Gist Richard-Gist moved this from Review to Ready for Demo in SwiftCurrent Kanban Jul 27, 2021
@brianlombardo brianlombardo moved this from Ready for Demo to Done in SwiftCurrent Kanban Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
SwiftCurrent Kanban
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes StoryboardLoadable protocol not working with AnyWorkflow.PassedArgs wwt/SwiftCurrent
1 participant
@Richard-Gist