Fixes StoryboardLoadable protocol not working with AnyWorkflow.PassedArgs #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue. - RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
|
Changes I made were in FlowRepresentable and AnyFlowRepresentable. I'm going to look at removing the force cast, next. Then I'll clean up all the code comments. |
…o UIKitExample app - RAG TT Co-authored-by: Richard Gist <Richard.Gist@wwt.com> Co-authored-by: Tyler Thompson <tyler.thompson@wwt.com>
Codecov Report
@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 94.68% 94.69% +0.01%
==========================================
Files 61 62 +1
Lines 1598 1603 +5
==========================================
+ Hits 1513 1518 +5
Misses 85 85
Continue to review full report at Codecov.
|
…RAG TT Co-authored-by: Richard Gist <Richard.Gist@wwt.com> Co-authored-by: Tyler Thompson <tyler.thompson@wwt.com>
Co-authored-by: Tyler Thompson <tyler.thompson@wwt.com> Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…e fixed our storyboardloadable factory with no args - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…d to update the example app tests to force abandon to be a thing - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
|
EOD: As @Tyler-Keith-Thompson pointed out in the last commit. We have gotten rid of some force casting, and everything is working BUT we still need to finish the example app for the Reject Terms of Service scenario. With the Reject of terms, we should also update the README to call out that screen as interesting. |
…he commit since he wrote such a good test that I only needed to modify a single line of it - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
morganzellers
previously approved these changes
Jul 27, 2021
wiemerm
previously approved these changes
Jul 27, 2021
…- TT RAG MW Co-authored-by: Tyler Thompson <tyler.thompson@wwt.com> Co-authored-by: Richard Gist <Richard.Gist@wwt.com> Co-authored-by: Megan Wiemer <megan.wiemer@wwt.com>
…talError - MW TT RAG Co-authored-by: Megan Wiemer <megan.wiemer@wwt.com> Co-authored-by: Tyler Thompson <tyler.thompson@wwt.com> Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
wiemerm
approved these changes
Jul 27, 2021
Tyler-Keith-Thompson
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue: Closes #80
Checklist: