Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some issues with preserving state while view swapping #114

Merged
merged 7 commits into from Aug 27, 2021

Conversation

Tyler-Keith-Thompson
Copy link
Collaborator

@Tyler-Keith-Thompson Tyler-Keith-Thompson commented Aug 26, 2021

Linked Issue:

Checklist:

…it belongs. Sadly, it is still untestable - TT
…g with view swapping, however the production code appears to be correct - TT RAG

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
@Tyler-Keith-Thompson
Copy link
Collaborator Author

While @Richard-Gist and I were working on marketing stuff we discovered a couple of issues with SwiftCurrent_SwiftUI. This PR addresses those issues.

NOTE: The issue of removing the cached content when .persistence(.removedAfterProceeding) is untestable as far as @Richard-Gist and I could tell. ViewInspector simply cannot get into the correct lifecycle methods to validate it.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

Merging #114 (c840ecb) into main (568758f) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   93.98%   94.13%   +0.14%     
==========================================
  Files          75       75              
  Lines        1813     1823      +10     
==========================================
+ Hits         1704     1716      +12     
+ Misses        109      107       -2     
Impacted Files Coverage Δ
...rces/SwiftCurrent_SwiftUI/Views/WorkflowItem.swift 93.51% <100.00%> (+1.85%) ⬆️
.../SwiftCurrent_SwiftUI/Views/WorkflowLauncher.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b1989...c840ecb. Read the comment docs.

Copy link
Collaborator

@Richard-Gist Richard-Gist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've already talked that the other scenario fixed is not testable at this time with the tools that we have.

@morganzellers morganzellers merged commit 16eaebb into main Aug 27, 2021
@morganzellers morganzellers deleted the fix-the-things branch August 27, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants