New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Full screen cover modal presentation style #121
Conversation
Co-authored-by: Tyler Thompson <tyler.thompson@wwt.com>
Co-authored-by: Tyler Thompson <tyler.thompson@wwt.com>
…ector tests to cover it - TT RAG Co-authored-by: Tyler Thompson <tyler.thompson@wwt.com>
Co-authored-by: Tyler Thompson <tyler.thompson@wwt.com>
Co-authored-by: Tyler Thompson <tyler.thompson@wwt.com>
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
==========================================
- Coverage 94.31% 91.64% -2.68%
==========================================
Files 77 79 +2
Lines 1883 2071 +188
==========================================
+ Hits 1776 1898 +122
- Misses 107 173 +66
Continue to review full report at Codecov.
|
EOD: Because fullScreenCover is untestable by ViewInspector, we will be adding our first XCUI tests. Additionally, For the XCUI tests, you can see the last commits working towards an idea for how they will work. Ultimately I think where we want to go with it is that there are about 4 FRs that are shared code between the UI tests and SwiftUIExample, and they allow customization by taking in some argument that determines their This makes most things Enum driven to talk between the test and the app, and the code readily available between the two for development. Hopefully, we'll end up with about 4 FR views we use for testing and hopefully only about 4 or so views holding |
… stuff working correctly, we will see what the pipeline says - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…st for our SwiftCurrent_SwiftUI target...if Xcode will be cool about that - TT
…OS build, not super thrilled with how it shaped up, though - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…before all the top level things - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…sed in just the best and most ridiculous way possible, fans of dot syntax will be thrilled - TT
…ooks like maybe there is a weird issue - TT
…lScreenCover - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
EOD: We have XCUITests that work...they really are just horrible tests to have to write. We will stick to ViewInspector as much as possible. I am currently satisfied by the level of testing the XCUITests provide. However, until now they were not running in the pipeline. We may need to tweak them so that they can run in the pipeline because I might have gotten too fancy with ResultBuilders for Xcode 12.4...we'll see. However, once our pipeline passes I am personally satisfied, let's ship out fullScreenCover. NOTE: A SwiftUI bug: |
…or of variadics for Xcode 12.4 - TT
…actually running in the pipeline - TT
Linked Issue: #119
Checklist: