Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets CI to only run on pushes to main branch #122

Merged
merged 1 commit into from Sep 2, 2021

Conversation

morganzellers
Copy link
Contributor

Checklist:

…n - MZ RAG

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
@morganzellers morganzellers requested a review from a team as a code owner September 2, 2021 18:51
@morganzellers morganzellers added this to In progress (NaN) in SwiftCurrent Kanban Sep 2, 2021
Copy link
Collaborator

@Richard-Gist Richard-Gist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So with this, we should only run this in Main, and everyone else will get it running in their main, or when they specifically request a run through workflow_dispatch. With our working methods, we will only run the tests once per commit instead of twice. AND it is now halving the boxes we use on each commit when we have a draft PR open.

We've discussed all this and this is what we want going forward.

@codecov-commenter
Copy link

Codecov Report

Merging #122 (6693c44) into main (e5150d4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files          77       77           
  Lines        1883     1883           
=======================================
  Hits         1776     1776           
  Misses        107      107           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c8821...6693c44. Read the comment docs.

@Richard-Gist Richard-Gist merged commit dfd5937 into main Sep 2, 2021
@Richard-Gist Richard-Gist deleted the updating-pipelines-ci branch September 2, 2021 20:17
@morganzellers morganzellers moved this from In progress (NaN) to Ready for Demo in SwiftCurrent Kanban Sep 7, 2021
@Richard-Gist Richard-Gist moved this from Ready for Demo to Done in SwiftCurrent Kanban Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants