Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New docs #126

Merged
merged 24 commits into from Sep 10, 2021
Merged

New docs #126

merged 24 commits into from Sep 10, 2021

Conversation

Tyler-Keith-Thompson
Copy link
Collaborator

@Tyler-Keith-Thompson Tyler-Keith-Thompson commented Sep 10, 2021 •
edited

Linked Issue:

Checklist:

@Tyler-Keith-Thompson Tyler-Keith-Thompson added the documentation Improvements or additions to documentation label Sep 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (release-swiftui@a5f5c4a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##             release-swiftui     #126   +/-   ##
==================================================
  Coverage                   ?   91.64%           
==================================================
  Files                      ?       79           
  Lines                      ?     2071           
  Branches                   ?        0           
==================================================
  Hits                       ?     1898           
  Misses                     ?      173           
  Partials                   ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f5c4a...d6321ed. Read the comment docs.

@Tyler-Keith-Thompson Tyler-Keith-Thompson marked this pull request as ready for review September 10, 2021 18:30
@Tyler-Keith-Thompson Tyler-Keith-Thompson requested a review from a team as a code owner September 10, 2021 18:30
Richard-Gist
Richard-Gist reviewed Sep 10, 2021
View reviewed changes
.github/abstract/Creating Workflows.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@Tyler-Keith-Thompson @Richard-Gist
[new-docs] - Fixed docs post processing so that it does not mangle li…
f04b04f 
…nks once it's nested in the folder structure - TT RAG

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
@Tyler-Keith-Thompson @Richard-Gist
Update .github/DocsPostProcessor/Package.swift
574fa51 
Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
@Tyler-Keith-Thompson
[new-docs] - the problem was fileURLWithPath, despite the fact that t…
fad9c4f 
…his is a file URL. That ended up causing all kinds of bizarre behavior that was undesirable, now we are good - TT
@Tyler-Keith-Thompson
Merge branch 'new-docs' of github.com:wwt/SwiftCurrent into new-docs
cdf8752
Richard-Gist
Richard-Gist approved these changes Sep 10, 2021
View reviewed changes
Copy link
Collaborator

@Richard-Gist Richard-Gist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Richard-Gist Richard-Gist merged commit 026047e into release-swiftui Sep 10, 2021
@Richard-Gist Richard-Gist deleted the new-docs branch September 10, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganzellers morganzellers morganzellers approved these changes

@Richard-Gist Richard-Gist Richard-Gist approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tyler-Keith-Thompson @codecov-commenter @morganzellers @Richard-Gist