Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces WorkflowLauncher and thenProceed(with:) with a new WorkflowView API, as discussed in #61 #179

Merged
merged 115 commits into from Mar 21, 2022

Conversation

Tyler-Keith-Thompson
Copy link
Collaborator

@Tyler-Keith-Thompson Tyler-Keith-Thompson commented Feb 21, 2022

Linked Issue: Closes #156

Checklist:


If Applicable:

  • Did you test when the first item is skipped?
  • Did you test when the last item is skipped?
  • Did you test when middle items are skipped?
  • Did you test when incorrect data is passed forward?
  • Did you test proceeding backwards?

If Public API Has Changed:

  • Did you deprecate (rather than remove) any old methods/variables/etc? Our philosophy for deprecation.
  • Have you done the best that you can to make sure that the compiler guides people to changing to the new API? (Example: the renamed attribute)
  • If necessary, have you tested the upgrade path for at least N-1 versions? For example, if data persists between v1 and v2 then that upgrade should be tested and as easy as we can make it.

Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>
Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>
…- mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
…owView - mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
… mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
…h WorkflowView - mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
…WorkflowView - mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
… mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
… WofkflowView - mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
…orklowView - mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
…able in WorkflowView - mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
…t type for first item in WorkflowView - mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
…able in the middle for WorkflowView - mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
…rkflowView - mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
…kflowView - mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
…specialize WorkflowItem - mf tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
…ions to specialize WorkflowItem - mf tt nk"

This reverts commit 9ac8d76.
… too - TT MF NK

Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022

Codecov Report

Merging #179 (94f06fe) into main (f69e8ac) will decrease coverage by 0.30%.
The diff coverage is 87.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   91.28%   90.97%   -0.31%     
==========================================
  Files          92      102      +10     
  Lines        2375     2538     +163     
==========================================
+ Hits         2168     2309     +141     
- Misses        207      229      +22     
Impacted Files Coverage Δ
...xample/Views/Settings/SettingsViewController.swift 0.00% <0.00%> (ø)
...UI/Deprecations/WorkflowLauncherDeprecations.swift 0.00% <0.00%> (ø)
...rent_SwiftUI/ViewModifiers/NavigationWrapper.swift 100.00% <ø> (ø)
...rent_SwiftUI/Protocols/_WorkflowItemProtocol.swift 25.00% <25.00%> (ø)
...Example/Views/Profile/AccountInformationView.swift 79.71% <41.17%> (ø)
...ftUIExample/SwiftUIExample/SwiftUIExampleApp.swift 92.30% <80.00%> (ø)
...ws/Settings/SettingsOnboardingViewController.swift 88.23% <88.23%> (ø)
ExampleApps/SwiftUIExample/Views/ContentView.swift 93.75% <100.00%> (+1.44%) ⬆️
ExampleApps/SwiftUIExample/Views/LoginView.swift 94.33% <100.00%> (ø)
...rrent_SwiftUI/ResultBuilders/WorkflowBuilder.swift 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad629b...94f06fe. Read the comment docs.

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>
Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>
Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>
morganzellers
morganzellers previously approved these changes Mar 18, 2022
…uncher. - nk tt

Co-authored-by: Tyler Thompson <tyler.thompson@wwt.com>
Copy link
Contributor

@nickkaczmarek nickkaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments about casing in the docs.

.github/abstract/Creating Workflows in SwiftUI.md Outdated Show resolved Hide resolved
.github/abstract/Creating Workflows.md Outdated Show resolved Hide resolved
Tyler-Keith-Thompson and others added 2 commits March 18, 2022 11:49
Co-authored-by: Nick Kaczmarek <nick.kaczmarek@wwt.com>
Co-authored-by: Nick Kaczmarek <nick.kaczmarek@wwt.com>
morganzellers
morganzellers previously approved these changes Mar 18, 2022
… to ensure we have compiled code for this feature. - nk
nickkaczmarek
nickkaczmarek previously approved these changes Mar 18, 2022
Copy link
Contributor

@nickkaczmarek nickkaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some UIKit interop code to ensure that we are definitely testing all the bits. I think we're ready to release!

.github/guides/Getting Started with SwiftUI.md Outdated Show resolved Hide resolved
Sources/SwiftCurrent_SwiftUI/Views/WorkflowItem.swift Outdated Show resolved Hide resolved
@nickkaczmarek nickkaczmarek dismissed stale reviews from themself via 8f91a0b March 18, 2022 21:28
nickkaczmarek
nickkaczmarek previously approved these changes Mar 18, 2022
@Tyler-Keith-Thompson Tyler-Keith-Thompson changed the title Replaces WorkflowLauncher and thenProceed(with:) with a new WorkflowView API, as discussed in #61 DO NOT MERGE Replaces WorkflowLauncher and thenProceed(with:) with a new WorkflowView API, as discussed in #61 Mar 21, 2022
@Tyler-Keith-Thompson Tyler-Keith-Thompson changed the title DO NOT MERGE Replaces WorkflowLauncher and thenProceed(with:) with a new WorkflowView API, as discussed in #61 Replaces WorkflowLauncher and thenProceed(with:) with a new WorkflowView API, as discussed in #61 Mar 21, 2022
@nickkaczmarek nickkaczmarek merged commit 40432d4 into main Mar 21, 2022
@nickkaczmarek nickkaczmarek deleted the workflow-builder branch March 21, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow thenProceed in preview providers
5 participants