-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a section to the Contributing guidelines covering how to install SwiftLint. #191
Conversation
I had started on this and totally didn't read your update this morning! 🤣 I confirmed on my personal machine that SwiftLint indeed needs to be installed before it'll work with our project so I'm glad this is in place. Didn't know about the pod install way though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment about the pod installation script, but otherwise looks good. Glad you have this markdown linter. I much prefer that style for bulleted lists.
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 92 92
Lines 2375 2375
=======================================
Hits 2168 2168
Misses 207 207 Continue to review full report at Codecov.
|
Also I think you want to update your PR template to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated your initial PR comment to close the issue. Merging now!
Linked Issue: Closes #189
Checklist: