Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a section to the Contributing guidelines covering how to install SwiftLint. #191

Merged
merged 3 commits into from
Mar 8, 2022

Conversation

morganzellers
Copy link
Contributor

@morganzellers morganzellers commented Mar 8, 2022

Linked Issue: Closes #189

Checklist:

@morganzellers morganzellers added the documentation Improvements or additions to documentation label Mar 8, 2022
@morganzellers morganzellers requested a review from a team as a code owner March 8, 2022 20:28
@morganzellers morganzellers changed the title Adds a section to the Contributing guidelines covering how to instal SwiftLint. Adds a section to the Contributing guidelines covering how to install SwiftLint. Mar 8, 2022
@nickkaczmarek
Copy link
Contributor

I had started on this and totally didn't read your update this morning! 🤣 I confirmed on my personal machine that SwiftLint indeed needs to be installed before it'll work with our project so I'm glad this is in place. Didn't know about the pod install way though.

Copy link
Contributor

@nickkaczmarek nickkaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about the pod installation script, but otherwise looks good. Glad you have this markdown linter. I much prefer that style for bulleted lists.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #191 (36cf48e) into main (edaedd0) will not change coverage.
The diff coverage is n/a.

❗ Current head 36cf48e differs from pull request most recent head f8269bf. Consider uploading reports for the commit f8269bf to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          92       92           
  Lines        2375     2375           
=======================================
  Hits         2168     2168           
  Misses        207      207           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6b7b22...f8269bf. Read the comment docs.

@nickkaczmarek nickkaczmarek added this to In progress (NaN) in SwiftCurrent Kanban Mar 8, 2022
@nickkaczmarek
Copy link
Contributor

Also I think you want to update your PR template to be Closes #189 so that it closes the issue.

Copy link
Contributor

@nickkaczmarek nickkaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated your initial PR comment to close the issue. Merging now!

@nickkaczmarek nickkaczmarek merged commit 63dc1af into main Mar 8, 2022
@nickkaczmarek nickkaczmarek deleted the contributing-swiftlint-update branch March 8, 2022 21:41
@morganzellers morganzellers moved this from In progress (NaN) to Ready for Demo in SwiftCurrent Kanban Mar 15, 2022
@morganzellers morganzellers moved this from Ready for Demo to Done in SwiftCurrent Kanban Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

The contribution guide (CONTRIBUTING.md) should have instructions for installing SwiftLint
3 participants