Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix-204] - Fixes #204 - TT #205

Merged
merged 3 commits into from Jun 12, 2022
Merged

[fix-204] - Fixes #204 - TT #205

merged 3 commits into from Jun 12, 2022

Conversation

Tyler-Keith-Thompson
Copy link
Collaborator

@Tyler-Keith-Thompson Tyler-Keith-Thompson commented Jun 12, 2022

Linked Issue: Closes #204

Checklist:


If Applicable:

  • Did you test when the first item is skipped?
  • Did you test when the last item is skipped?
  • Did you test when middle items are skipped?
  • Did you test when incorrect data is passed forward?
  • Did you test proceeding backwards?

If Public API Has Changed:

  • Did you deprecate (rather than remove) any old methods/variables/etc? Our philosophy for deprecation.
  • Have you done the best that you can to make sure that the compiler guides people to changing to the new API? (Example: the renamed attribute)
  • If necessary, have you tested the upgrade path for at least N-1 versions? For example, if data persists between v1 and v2 then that upgrade should be tested and as easy as we can make it.

@Tyler-Keith-Thompson
Copy link
Collaborator Author

Assuming the pipeline passes and given the severity of the bug I'm going to self-approve.

@Tyler-Keith-Thompson Tyler-Keith-Thompson merged commit 5618a23 into main Jun 12, 2022
@Tyler-Keith-Thompson Tyler-Keith-Thompson deleted the fix-204 branch June 12, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Abandon does not dismiss SwiftUI Nav stack
1 participant