Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build crash fix #217

Merged
merged 6 commits into from
Nov 5, 2022
Merged

Build crash fix #217

merged 6 commits into from
Nov 5, 2022

Conversation

Richard-Gist
Copy link
Collaborator

@Richard-Gist Richard-Gist commented Nov 4, 2022 •
edited
Loading

Linked Issue:

#216

Checklist:

@Richard-Gist
Copy link
Collaborator Author

Creating this PR to get it into the public eye for a possible fix.

@Richard-Gist Richard-Gist marked this pull request as ready for review November 5, 2022 14:45
@Richard-Gist Richard-Gist linked an issue Nov 5, 2022 that may be closed by this pull request
[Bug]: Build crashes when running tests #216
Closed
1 task
Tyler-Keith-Thompson
Tyler-Keith-Thompson approved these changes Nov 5, 2022
View reviewed changes
Copy link
Collaborator

@Tyler-Keith-Thompson Tyler-Keith-Thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this was necessary, but I see no issue with it.

@Tyler-Keith-Thompson Tyler-Keith-Thompson added the maintenance Improvements or additions to configuration files label Nov 5, 2022
@Tyler-Keith-Thompson Tyler-Keith-Thompson merged commit 854fdb8 into wwt:main Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyler-Keith-Thompson Tyler-Keith-Thompson Tyler-Keith-Thompson approved these changes

Assignees
No one assigned
Labels
maintenance Improvements or additions to configuration files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Build crashes when running tests
2 participants
@Richard-Gist @Tyler-Keith-Thompson