Fixes removedAfterProceeding not dismissing final view when applied to final item in Workflow. #33

Richard-Gist · 2021-06-02T19:56:01Z

Linked Issue: Fixes #19

Checklist:

If Applicable:

Did you test when the first item is skipped?
Did you test when the last item is skipped?
Did you test when middle items are skipped?
Did you test when incorrect data is passed forward?
Did you test proceeding backwards?

If Public API Has Changed:

Did you deprecate (rather than remove) any old methods/variables/etc? Our philosophy for deprecation.
Have you done the best that you can to make sure that the compiler guides people to changing to the new API? (Example: the renamed attribute)
If necessary, have you tested the upgrade path for at least N-1 versions? For example, if data persists between v1 and v2 then that upgrade should be tested and as easy as we can make it.

… OrchestrationResponderTests implemented. - MOB

…with changes to mock - MOB

Richard-Gist · 2021-06-02T20:00:08Z

~~This should have been a draft!!~~

EOD: We have decided to create a "complete" function on OrchestrationResponder and it will have the sole responsibility of calling the onFinish provided to the Workflow. In driving out these tests, we decided that the MockOrchestrationResponder should have the ability to call a default implementation. In this case, the default is that complete will call onFinish with the passedArgs.

These decisions are being worked through and the current state of the PR is incomplete for all of those decisions.

…ceeding in workflow. Back to passing tests in Workflow - MOB

… shouldLoad path to complete - MW RAG

…g and sonar cloud - MW RAG

… - RAG

…arios, excluding last test which will fail - RAG

Sources/WorkflowUIKit/UIKitPresenter.swift

… calling the correct thing. Made it incorrect so we can still TDD it out. Also enabled swiftlint again - RAG

Sources/Workflow/Models/Workflow.swift

… the last item in a Workflow is not loaded - MOB

…re functionality - MOB

…documentation - MOB

… - MOB

…adedInstance - MOB

wiemerm · 2021-06-04T20:01:04Z

EOD: We addressed existing comments.

…onar too - MOB

…. Another code smell fix - MOB

…sented a new ViewController - BL MW

wiemerm · 2021-06-07T20:02:07Z

EOD: We're continuing with the solution that we had spiked on previously in handling calling onFinish() in our private destroy method.

…roller - BL+MW

Richard-Gist

Also, we need to generate new docs for this.

Sources/WorkflowUIKit/UIKitPresenter.swift

Tests/WorkflowExampleTests/Mocks/MockOrchestrationResponder.swift

Tests/WorkflowTests/LinkedListTests.swift

Sources/Workflow/Models/Workflow.swift

Tests/WorkflowExampleTests/Mocks/MockOrchestrationResponder.swift

Tests/WorkflowTests/LinkedListTests.swift

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

…owExampleTests MockOrchestrationResponder - MW

Sources/Workflow/Protocols/OrchestrationResponder.swift

…ith WorkflowUIKit - RAG

…er cleanup and streamlines calls - MOB

…Presenter - MOB

wiemerm · 2021-06-09T16:32:56Z

Good to merge after the docs are updated.

… to docs for LInkedList - MOB

sonarcloud · 2021-06-09T16:46:32Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

86.7% Coverage
0.0% Duplication

Richard-Gist added 3 commits June 2, 2021 13:30

[removedAfterProceeding] - Adding complete to OrchestrationResponder.…

818749b

… OrchestrationResponderTests implemented. - MOB

[removedAfterProceeding] - Updated PersistenceTests in WorkflowTests …

502c8c3

…with changes to mock - MOB

[removedAfterProceeding] - updated SkipThroughWorkflowTests - MOB

bcaee74

Richard-Gist added the bug Something isn't working label Jun 2, 2021

cla-bot bot added the cla-signed label Jun 2, 2021

Richard-Gist marked this pull request as draft June 2, 2021 20:00

Richard-Gist added 5 commits June 2, 2021 14:13

[removedAfterProceeding] - Updated Workflow to call complete when pro…

ff7b0d5

…ceeding in workflow. Back to passing tests in Workflow - MOB

[removedAfterProceeding] - Adding warning so we dont forget to do the…

aadfd9a

… shouldLoad path to complete - MW RAG

[removedAfterProceeding] - back to green but should be failing lintin…

da45b6d

…g and sonar cloud - MW RAG

[removedAfterProceeding] - minor linting and sonarcloud smells fixing…

83c9618

… - RAG

[removedAfterProceeding] - Adding additional tests to cover more scen…

0c170b2

…arios, excluding last test which will fail - RAG

Tyler-Keith-Thompson reviewed Jun 2, 2021

View reviewed changes

Sources/WorkflowUIKit/UIKitPresenter.swift Outdated Show resolved Hide resolved

[removedAfterProceeding] - call to complete was a round-a-bout way of…

b2e82a5

… calling the correct thing. Made it incorrect so we can still TDD it out. Also enabled swiftlint again - RAG

Richard-Gist commented Jun 2, 2021

View reviewed changes

Sources/Workflow/Models/Workflow.swift Outdated Show resolved Hide resolved

morganzellers and others added 5 commits June 4, 2021 11:22

[removedAfterProceeding] - Adds support for destroying all items when…

829878d

… the last item in a Workflow is not loaded - MOB

[removedAfterProceeding] Adds implementation for linked list last whe…

7bb55bd

…re functionality - MOB

[removedAfterProceeding] - Adds tests to LinkedList.last(where:) and …

3243278

…documentation - MOB

[removedAfterProceeding] Replaces filter and last with a last(where:)…

68fde9a

… - MOB

[removedAfterProceeding] Immediately completes if there's no first lo…

08880e8

…adedInstance - MOB

Richard-Gist added 2 commits June 4, 2021 14:15

[removedAfterProceeding] - Making Tyler and the styleguide happy... S…

3184d37

…onar too - MOB

[removedAfterProceeding] - I should have done this in the last commit…

b1c6206

…. Another code smell fix - MOB

morganzellers previously approved these changes Jun 4, 2021

View reviewed changes

[removedAfterProceeding] - Adds completion call to destroy - MOB

7405cf7

wiemerm dismissed morganzellers’s stale review via 7405cf7 June 7, 2021 19:04

[removedAfterProceeding] Calls completion even when workflow item pre…

383294b

…sented a new ViewController - BL MW

lombardb added 2 commits June 8, 2021 11:02

Merge branch 'main' into removedAfterProceeding

a9fda4e

[removedAfterProceeding] - Cleans up the self created navigation cont…

77d5717

…roller - BL+MW

lombardb and others added 2 commits June 8, 2021 13:23

[removedAfterProceeding] - Renames test to be more accurate - MOB

a11c6eb

[removedAfterProceeding] - Adds _ to last(where:) - MOB

c89766b

morganzellers previously approved these changes Jun 8, 2021

View reviewed changes

wiemerm marked this pull request as ready for review June 8, 2021 18:58

Richard-Gist commented Jun 8, 2021

View reviewed changes

wiemerm suggested changes Jun 8, 2021

View reviewed changes

Tests/WorkflowExampleTests/Mocks/MockOrchestrationResponder.swift Outdated Show resolved Hide resolved

Tests/WorkflowTests/LinkedListTests.swift Outdated Show resolved Hide resolved

Update Tests/WorkflowTests/LinkedListTests.swift

41e83a5

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

wiemerm dismissed stale reviews from morganzellers via 41e83a5 June 8, 2021 19:29

[removedAfterProceeding] - Adds implementation for complete in Workfl…

fc34132

…owExampleTests MockOrchestrationResponder - MW

Richard-Gist added the documentation Improvements or additions to documentation label Jun 8, 2021

Richard-Gist commented Jun 8, 2021

View reviewed changes

Sources/Workflow/Protocols/OrchestrationResponder.swift Show resolved Hide resolved

Richard-Gist added 2 commits June 8, 2021 16:33

[removedAfterProceeding] - Adding test coverage for if all FRs skip w…

9af0375

…ith WorkflowUIKit - RAG

[removedAfterProceeding] - Ramped minor version

7060832

Richard-Gist requested a review from a team as a code owner June 8, 2021 22:58

[removedAfterProceeding] - Removes unnecessary code for view controll…

e8824ea

…er cleanup and streamlines calls - MOB

wiemerm previously approved these changes Jun 9, 2021

View reviewed changes

[removedAfterProceeding] - Adding documentation to complete on UIKite…

a90d7ef

…Presenter - MOB

[removedAfterProceeding] - Generated docs and made minor improvements…

8e9e190

… to docs for LInkedList - MOB

Richard-Gist dismissed wiemerm’s stale review via 8e9e190 June 9, 2021 16:40

wiemerm approved these changes Jun 9, 2021

View reviewed changes

morganzellers approved these changes Jun 9, 2021

View reviewed changes

Richard-Gist merged commit c651d74 into main Jun 9, 2021

Richard-Gist deleted the removedAfterProceeding branch June 9, 2021 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes removedAfterProceeding not dismissing final view when applied to final item in Workflow. #33

Fixes removedAfterProceeding not dismissing final view when applied to final item in Workflow. #33

Richard-Gist commented Jun 2, 2021 •

edited

Richard-Gist commented Jun 2, 2021 •

edited

wiemerm commented Jun 4, 2021

wiemerm commented Jun 7, 2021 •

edited

Richard-Gist left a comment

wiemerm commented Jun 9, 2021

sonarcloud bot commented Jun 9, 2021

Fixes removedAfterProceeding not dismissing final view when applied to final item in Workflow. #33

Fixes removedAfterProceeding not dismissing final view when applied to final item in Workflow. #33

Conversation

Richard-Gist commented Jun 2, 2021 • edited

Linked Issue: Fixes #19

Checklist:

If Applicable:

If Public API Has Changed:

Richard-Gist commented Jun 2, 2021 • edited

wiemerm commented Jun 4, 2021

wiemerm commented Jun 7, 2021 • edited

Richard-Gist left a comment

Choose a reason for hiding this comment

wiemerm commented Jun 9, 2021

sonarcloud bot commented Jun 9, 2021

Richard-Gist commented Jun 2, 2021 •

edited

Richard-Gist commented Jun 2, 2021 •

edited

wiemerm commented Jun 7, 2021 •

edited