Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR Template to direct contributors to remove unneeded checklist items #83

Merged
merged 2 commits into from
Jul 27, 2021

Conversation

morganzellers
Copy link
Contributor

@morganzellers morganzellers commented Jul 27, 2021

Checklist:


…g the contributor to remove unneeded checklist items - MZ

Co-authored-by: Morgan Zellers <morgan.zellers@gmail.com>
@morganzellers morganzellers requested a review from a team as a code owner July 27, 2021 13:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #83 (664f2e3) into main (ecd303a) will decrease coverage by 3.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   97.76%   94.68%   -3.09%     
==========================================
  Files          89       61      -28     
  Lines        5095     1598    -3497     
==========================================
- Hits         4981     1513    -3468     
+ Misses        114       85      -29     
Impacted Files Coverage Δ
...UIExampleTests/Views/ChangeUsernameViewTests.swift
...ts/Views/QRScannerFeatureOnboardingViewTests.swift
...nt_UIKitTests/TestUtilities/CustomAssertions.swift
...pleTests/ViewInspector/ViewHostingExtensions.swift
...e/SwiftCurrent_UIKitTests/UIKitConsumerTests.swift
...ample/SwiftUIExampleTests/Views/MFAViewTests.swift
...ampleTests/Views/AccountInformationViewTests.swift
...Current_UIKitTests/UIKitConsumerAbandonTests.swift
...pleTests/Views/MapFeatureOnboardingViewTests.swift
...wiftUIExampleTests/Views/MapFeatureViewTests.swift
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1afc14f...664f2e3. Read the comment docs.

@Richard-Gist
Copy link
Collaborator

I like how clean the final checklist looks. Do we have a plan for if the requester removes some items they didn't know they needed to do? I'm thinking like a version ramp because what they thought was a bug fix actually was an API change?

@morganzellers
Copy link
Contributor Author

I like how clean the final checklist looks. Do we have a plan for if the requester removes some items they didn't know they needed to do? I'm thinking like a version ramp because what they thought was a bug fix actually was an API change?

That's something I was trying to consider as well. I don't really have any ideas other than us doing our due diligence to check the checklist against the changes.

@morganzellers morganzellers added the documentation Improvements or additions to documentation label Jul 27, 2021
@Richard-Gist Richard-Gist merged commit da2085c into main Jul 27, 2021
@Richard-Gist Richard-Gist moved this from Review to Ready for Demo in SwiftCurrent Kanban Jul 27, 2021
@brianlombardo brianlombardo moved this from Ready for Demo to Done in SwiftCurrent Kanban Jul 29, 2021
@Richard-Gist Richard-Gist deleted the update-pr-template branch August 3, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants