fix: add support for UTF-8 and Unicode in guac.Parse #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for pointing this out, looks like we have some other places that needs to be UTF-8 aware as well. It's interesting though that this hasn't come up for us before. I guess most of the time the UTF-8 is a single byte. |
jakecoffman
requested changes
Feb 1, 2022
Open
This commit adds support for UTF-8 and Unicode in the guac.Parse func. We also check for lengths before accessing the data buffer array. In this commit we also add some tests to cover these edge cases.
|
Ok, perfect, I should have resolved everything, let me know if I forgot something. In the next weeks I'll send other PRs to implement the file transfer REST endpoints along with a new Tunnel implementation beside the already present SimpleTunnel. That one will be much bigger than this one, I'm afraid :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for UTF-8 and Unicode in the guac.Parse func.
We also check for lengths before accessing the data buffer array.
In this commit we also add some tests to cover these edge cases.