Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test (new, 2nd) Preview #42

Closed
wants to merge 7 commits into from
Closed

Conversation

vorburger
Copy link
Contributor

@vorburger vorburger commented Nov 2, 2023

This is another test like #35, after #40.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
Copy link

github-actions bot commented Nov 2, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.59s
✅ EDITORCONFIG editorconfig-checker 1 0 0.02s
✅ HTML djlint 1 0 1.07s
✅ HTML htmlhint 1 0 0.4s
✅ REPOSITORY checkov yes no 17.76s
✅ REPOSITORY gitleaks yes no 0.23s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 10.19s
✅ REPOSITORY secretlint yes no 0.69s
✅ REPOSITORY trivy yes no 6.82s
✅ REPOSITORY trivy-sbom yes no 1.05s
✅ REPOSITORY trufflehog yes no 3.34s
✅ SPELL lychee 1 0 1.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Nov 2, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-02 05:04 UTC

@vorburger
Copy link
Contributor Author

After #43, this finally did post a preview URL:

🚀 Deployed preview to https://www-learn-study.github.io/previews/pr-preview/pr-42/

Except it's still wrong...

(a) the path is wrong (missing www-learn-study/saraswati.learn.study/ prefix), and

(b) there is no /pr-42/ on https://github.com/www-learn-study/previews/commits/gh-pages ?!

@vorburger vorburger marked this pull request as ready for review November 2, 2023 03:26
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
@vorburger
Copy link
Contributor Author

#44 (with 433f483) fixed rossjrw/pr-preview-action#63, and the fatal error is gone.

However, https://www-learn-study.github.io/previews/pr-preview/pr-42/ still does not include this change?!

I wonder if https://github.com/www-learn-study/previews/ is misconfigured... it shouldn't need any Actions!?

vorburger added a commit to www-learn-study/previews that referenced this pull request Nov 2, 2023
see www-learn-study/saraswati.learn.study#42 (comment)

Because this is not required, given that https://github.com/www-learn-study/previews/settings/pages is configured to _Deploy from a branch,_ and may be creating havoc? (And is just slower anyway as well; you get the comment that the preview site is available before it's actually live.)
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
@vorburger
Copy link
Contributor Author

However, https://www-learn-study.github.io/previews/pr-preview/pr-42/ still does not include this change?!

because in https://github.com/www-learn-study/saraswati.learn.study/actions/runs/6728224458/job/18287234915?pr=42 git checked out the main branch and not this PR?! I don't understand why, yet. What could be wrong in:

- name: Checkout PR head
        if: ${{ startsWith(github.event_name, 'pull_request') && github.event.action != 'closed' }}
        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

It works in https://github.com/www-learn-study/saraswati.learn.study/actions/runs/6728224523/job/18287235048?pr=42 for the MegaLinter workflow:

- name: Checkout Code
        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          fetch-depth: 0

@vorburger vorburger mentioned this pull request Nov 2, 2023
vorburger added a commit that referenced this pull request Nov 2, 2023
Hopefully this will fix #42 (comment)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
@vorburger vorburger closed this in #46 Nov 2, 2023
vorburger added a commit that referenced this pull request Nov 2, 2023
Hopefully this will fix #42 (comment)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
@vorburger vorburger reopened this Nov 2, 2023
vorburger added a commit that referenced this pull request Nov 2, 2023
@vorburger vorburger closed this in #47 Nov 2, 2023
vorburger added a commit that referenced this pull request Nov 2, 2023
@vorburger vorburger reopened this Nov 2, 2023
@vorburger
Copy link
Contributor Author

OMG, now https://www-learn-study.github.io/previews/pr-preview/pr-42/ finally showed hello, world?!, including this change.

@vorburger vorburger closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant