New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test (new, 2nd) Preview #42
Conversation
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
|
After #43, this finally did post a preview URL:
Except it's still wrong... (a) the path is wrong (missing (b) there is no |
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
#44 (with 433f483) fixed rossjrw/pr-preview-action#63, and the fatal error is gone. However, https://www-learn-study.github.io/previews/pr-preview/pr-42/ still does not include this change?! I wonder if https://github.com/www-learn-study/previews/ is misconfigured... it shouldn't need any Actions!? |
see www-learn-study/saraswati.learn.study#42 (comment) Because this is not required, given that https://github.com/www-learn-study/previews/settings/pages is configured to _Deploy from a branch,_ and may be creating havoc? (And is just slower anyway as well; you get the comment that the preview site is available before it's actually live.)
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
because in https://github.com/www-learn-study/saraswati.learn.study/actions/runs/6728224458/job/18287234915?pr=42 git checked out the - name: Checkout PR head
if: ${{ startsWith(github.event_name, 'pull_request') && github.event.action != 'closed' }}
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 It works in https://github.com/www-learn-study/saraswati.learn.study/actions/runs/6728224523/job/18287235048?pr=42 for the MegaLinter workflow: - name: Checkout Code
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
token: ${{ secrets.GITHUB_TOKEN }}
fetch-depth: 0 |
Hopefully this will fix #42 (comment) Signed-off-by: Michael Vorburger <mike@vorburger.ch>
Hopefully this will fix #42 (comment) Signed-off-by: Michael Vorburger <mike@vorburger.ch>
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
…ll_request_target) This should hopefully finally fix #42 (comment). See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target Signed-off-by: Michael Vorburger <mike@vorburger.ch>
…ll_request_target) This should hopefully finally fix #42 (comment). See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target Signed-off-by: Michael Vorburger <mike@vorburger.ch>
OMG, now https://www-learn-study.github.io/previews/pr-preview/pr-42/ finally showed |
This is another test like #35, after #40.