Issue #175 bugfixes after testing ongoing

wwwouaiebe · Sep 5, 2021 · 28637fa · 28637fa
1 parent cbfff78
commit 28637fa
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/buildNumber.json b/buildNumber.json
@@ -1 +1 @@
-{ "buildNumber" : "02716"}
+{ "buildNumber" : "02717"}
diff --git a/src/coreLib/HTMLSanitizer.js b/src/coreLib/HTMLSanitizer.js
@@ -469,12 +469,12 @@ class HTMLSanitizer {
 			targetNode.textContent = '';
 		}
 	}
-	
+
 	/**
 	This method clone a DOM node, removing all invalid childs and attributes
 	@param {HTMLElement} htmlElement the node to clone
 	*/
-	
+
 	clone ( htmlElement ) {
 		let clone = document.createElement ( htmlElement.tagName );
 		this.#cloneNode ( htmlElement, clone );

diff --git a/src/dialogBase/BaseDialog.js b/src/dialogBase/BaseDialog.js
@@ -564,7 +564,9 @@ class BaseDialog {
 		if ( this.canClose ( ) ) {
 			this.#destructor ( );
 			this.#onPromiseOkFct ( returnValue );
+			return true;
 		}
+		return false;
 	}
 
 	/**

diff --git a/src/dialogNotes/NoteDialog.js b/src/dialogNotes/NoteDialog.js
@@ -264,8 +264,9 @@ class NoteDialog extends BaseDialog {
 	}
 
 	onOk ( ) {
-		this.#destructor ( );
-		super.onOk ( );
+		if ( super.onOk ( ) ) {
+			this.#destructor ( );
+		}
 	}
 
 	/**