Fix building with Python 3.8 on Linux #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3.8, running "python3-config --libs" no longer returns the python library itself. This causes Waf's pyembed check to fail as it can't resolve references to methods in the python library. There is discussion[1] ongoing about adding an "embed" mode to python3-config, but at the moment it is not implemented. We can work around this, however, in wxPython, by invoking Waf's check_python_headers() with just the "pyext" feature as "pyembed" isn't needed in wxPython (as far as I can tell). [1] https://bugs.python.org/issue36721
|
Thanks, I've been meaning to check if this is possible for some other reasons as well. |
RobinD42
added a commit
to RobinD42/Phoenix
that referenced
this pull request
May 20, 2019
Fix building with Python 3.8 on Linux (cherry picked from commit c74a933)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3.8, running "python3-config --libs" no longer returns the python
library itself. This causes Waf's pyembed check to fail as it can't resolve
references to methods in the python library. There is discussion[1] ongoing
about adding an "embed" mode to python3-config, but at the moment it is not
implemented. We can work around this, however, in wxPython, by invoking Waf's
check_python_headers() with just the "pyext" feature as "pyembed" isn't needed
in wxPython (as far as I can tell).
[1] https://bugs.python.org/issue36721