Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

size problem with agw.auibook #358

Closed
mprosperi opened this issue May 13, 2017 · 5 comments · Fixed by #593
Closed

size problem with agw.auibook #358

mprosperi opened this issue May 13, 2017 · 5 comments · Fixed by #593
Assignees

Comments

@mprosperi
Copy link
Contributor

in aui_notebook demo, if you drag a tab and drop it near a border of the auibook you get two visible book pages as expected. But in Classic they have the same size while in Phoenix (latest snapshot and a2) the new one is very narrow. Comparing auibook.py files of Classic and Phoenix I can't see any explicit statement on sizes that could explain this (python 3.5-64, win7)

@zanfio
Copy link

zanfio commented Oct 19, 2017

@infinity77
Copy link
Contributor

infinity77 commented Nov 5, 2017

Hi,

this specific issue on auibook.py seems to be fixed on my machine (Python 2.7 64 bit Windows 7, wxPython 4.0.0b2 msw) with the ridiculously simple patch attached.

@mprosperi , could you please test and see if it works?

auibook_patch.txt

Andrea.

@mprosperi
Copy link
Contributor Author

yes, it works, thank you. Split method needs the same patch too

@infinity77
Copy link
Contributor

Deal, I’ll patch it and make a pull request for Robin to apply... I’m not sure if I still have the write access rights I used to have back in time 😊

infinity77 added a commit to infinity77/Phoenix that referenced this issue Nov 5, 2017
@infinity77
Copy link
Contributor

Pull request up and running: #593

RobinD42 added a commit that referenced this issue Nov 9, 2017
fix aui/auibook.py for issue #358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants