Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags missing in Phoenix #397

Open
Metallicow opened this issue Jun 15, 2017 · 2 comments
Open

Flags missing in Phoenix #397

Metallicow opened this issue Jun 15, 2017 · 2 comments

Comments

@Metallicow
Copy link
Contributor

These flags are missing from Phoenix. They were in classic.
There is also no infos for these in the Classic vs Phoenix

wx.TE_AUTO_SCROLL
wx.TE_CAPITALIZE
wx.TE_LINEWRAP

wx.TR_COLUMN_LINES
wx.TR_DONT_ADJUST_MAC
wx.TR_EXTENDED
wx.TR_MAC_BUTTONS
wx.TR_VIRTUAL

@Metallicow
Copy link
Contributor Author

Metallicow commented Jun 15, 2017

wx.BU_AUTODRAW
There is no window styles documentation for this in the new phoenix docs.
There is old documentation here https://wxpython.org/docs/api/wx.BitmapButton-class.html and here http://xoomer.virgilio.it/infinity77/wxPython/Widgets/wx.BitmapButton.html

@mesalu
Copy link
Collaborator

mesalu commented Jun 20, 2017

I've done some digging though wxWidgets itself. Forewarning, I'm looking at master, not WX_3_0_BRANCH

wxTE_CAPITALIZE

wxTE_CAPITALIZE looks like it has been limited to wxOSX_IPHONE, where it is defined as wxTE_RICH2, and 0 otherwise.

#if defined(__WXOSX_IPHONE__)
#define wxTE_CAPITALIZE     wxTE_RICH2
#else
#define wxTE_CAPITALIZE     0
#endif

Safe to say that this is deliberately omitted.

wxTE_AUTO_SCROLL

As for TE_AUTO_SCROLL:
it is now set as default behavior, and is not intended for direct use. (Unless you're using wxWidgets 2.8)

#if WXWIN_COMPATIBILITY_2_8
    // this style is (or at least should be) on by default now, don't use it
    #define wxTE_AUTO_SCROLL    0
#endif // WXWIN_COMPATIBILITY_2_8

wxTE_LINEWRAP

wxTE_LINEWRAP is missing altogether from wx/include/textctrl.h. Maybe it's defined elsewhere? I'll do some git diving later to try and find out what happened to it, but for now I think its safe to assume its gone intentionally.

wxTR_COLUMN_LINES

This macro is missing in both treebase.h and defs.h, probably the same boat as TE_LINEWRAP

wxTR_DONT_ADJUST_MAC

Same story as the previous two macros

wxTR_EXTENDED

Similar to TE_AUTO_SCROLL, its still kicking around for backwards compatibility with 2_8. As Phoenix is built on 3_0, it shouldn't be relevant.

wxTR_MAC_BUTTONS

This macro is also MIA

wxTR_VIRTUAL

This macro is also MIA

wxBU_AUTODRAW

From include/wx/anybutton.h

// These two flags are obsolete
#define wxBU_NOAUTODRAW      0x0000
#define wxBU_AUTODRAW        0x0004

Summary:

Some of these are missing from wxWidgets master branch, when I get more free time I'd be willing to dive into why they're just gone altogether.
The rest look to be obsoleted / only around for 2_8

~~Mesalu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants