wx.agw.aui: don't uninitialize the AuiManager if the window close event is vetoed #2460

tmszi · 2023-09-22T06:15:11Z

Ssucessfully tested with wxPython demo example wxPython-demo-4.2.1/demo/agw/AUI.py file with modified AuiFrame() class OnClose() close event method handler.

    def OnClose(self, event):
       dlg = wx.MessageDialog(
            self,
            'Do you really want to close this window?',
            'Confirm',
            wx.YES_NO | wx.NO_DEFAULT | wx.ICON_QUESTION
       ).ShowModal()
       if dlg == wx.ID_NO:
           event.Veto()
           return
       self.timer.Stop()
       event.Skip()

…nt is vetoed

Which override base OnClose window close event handler method to prevent prematurely uninitialize manager. wxWidgets/Phoenix#2460

…3177) * wxGUI/main_window: add and use custom SingleWindowAuiManager class Which override base OnClose window close event handler method to prevent prematurely uninitialize manager. wxWidgets/Phoenix#2460 * Update the package documentation class list

…SGeo#3177) * wxGUI/main_window: add and use custom SingleWindowAuiManager class Which override base OnClose window close event handler method to prevent prematurely uninitialize manager. wxWidgets/Phoenix#2460 * Update the package documentation class list

tatarize

Checked this and the problem being fixed is entirely valid.

…SGeo#3177) * wxGUI/main_window: add and use custom SingleWindowAuiManager class Which override base OnClose window close event handler method to prevent prematurely uninitialize manager. wxWidgets/Phoenix#2460 * Update the package documentation class list

wx.agw.aui: don't uninitialize the AuiManager if the window close eve…

53574e3

…nt is vetoed

tmszi mentioned this pull request Sep 22, 2023

[Bug] It is not possible minimize/maximize/resize/move Data Catalog, Layers, Tools pane after the wxGUI quit dialog is closed OSGeo/grass#2647

Closed

tmszi added a commit to tmszi/grass that referenced this pull request Sep 22, 2023

wxGUI/main_window: add and use custom SingleWindowAuiManager class

25cf5ce

Which override base OnClose window close event handler method to prevent prematurely uninitialize manager. wxWidgets/Phoenix#2460

tmszi mentioned this pull request Sep 22, 2023

wxGUI/main_window: add and use custom SingleWindowAuiManager class OSGeo/grass#3177

Merged

tatarize approved these changes Dec 18, 2023

View reviewed changes

swt2c merged commit 525dd03 into wxWidgets:master Dec 18, 2023
10 of 21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wx.agw.aui: don't uninitialize the AuiManager if the window close event is vetoed #2460

wx.agw.aui: don't uninitialize the AuiManager if the window close event is vetoed #2460

tmszi commented Sep 22, 2023 •

edited

tatarize left a comment

wx.agw.aui: don't uninitialize the AuiManager if the window close event is vetoed #2460

wx.agw.aui: don't uninitialize the AuiManager if the window close event is vetoed #2460

Conversation

tmszi commented Sep 22, 2023 • edited

tatarize left a comment

Choose a reason for hiding this comment

tmszi commented Sep 22, 2023 •

edited