Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current SVN [74819] doesn't build with VS2005 #15500

Closed
wxtrac opened this issue Sep 15, 2013 · 1 comment
Closed

Current SVN [74819] doesn't build with VS2005 #15500

wxtrac opened this issue Sep 15, 2013 · 1 comment
Labels
build Any build issue (with or without CMake) v3.0

Comments

@wxtrac
Copy link
Collaborator

wxtrac commented Sep 15, 2013

Issue migrated from trac ticket # 15500

component: build | priority: normal | resolution: fixed

2013-09-15 13:40:13: ericj created the issue


Current SVN [74819] breaks compilation with VS2005.

All errors are caused by msw/dbghelp.h. I don't know if this code is supposed to work with VS2005, but as a quick fix for me, i changed the

#if API_VERSION_NUMBER >= 9
to
#if API_VERSION_NUMBER >= 10

so it doesn't get used with VS2005.

Example errors (191 in total):

c:\SVN\wxWidgets\include\wx/msw/debughlp.h(220) : error C2059: syntax error : '<L_TYPE_raw>'
c:\SVN\wxWidgets\include\wx/msw/debughlp.h(220) : error C2238: unexpected token(s) preceding ';'
c:\SVN\wxWidgets\include\wx/msw/debughlp.h(228) : error C2061: syntax error : identifier 'PENUMLOADED_MODULES_CALLBACKW64'
c:\SVN\wxWidgets\include\wx/msw/debughlp.h(230) : error C2061: syntax error : identifier 'PSYMBOL_INFOW'
c:\SVN\wxWidgets\include\wx/msw/debughlp.h(231) : error C2061: syntax error : identifier 'PIMAGEHLP_LINEW64'
c:\SVN\wxWidgets\include\wx/msw/debughlp.h(232) : error C2061: syntax error : identifier 'PSYM_ENUMERATESYMBOLS_CALLBACKW'
c:\SVN\wxWidgets\include\wx/msw/debughlp.h(300) : error C2146: syntax error : missing ';' before identifier 'SymGetLineFromAddrW64'

Static build, 32bit mode.

@wxtrac
Copy link
Collaborator Author

wxtrac commented Sep 15, 2013

2013-09-15 13:57:24: @vadz changed status from new to closed

2013-09-15 13:57:24: @vadz set resolution to fixed

2013-09-15 13:57:24: @vadz commented

(In [74820]) Revert "Make wxMSW stack walking methods work with Unicode identifiers."

This reverts 74817 because it broke compilation with VC8 and it doesn't seem
obvious to fix this.

See #15138, closes #15500.

@wxtrac wxtrac closed this as completed Sep 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Any build issue (with or without CMake) v3.0
Projects
None yet
Development

No branches or pull requests

1 participant