Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tree icons in wxTreeCtrl #23255

Closed
funnydog opened this issue Feb 13, 2023 · 2 comments
Closed

Missing tree icons in wxTreeCtrl #23255

funnydog opened this issue Feb 13, 2023 · 2 comments
Labels
regression Worked previously, doesn't work any longer

Comments

@funnydog
Copy link

Description

After Arch Linux upgraded wxWidgets to version 3.2.2 the icons in the main KiCad window aren't shown anymore (bugreport: https://bugs.archlinux.org/task/77476).

Screenshot of the problem

Looking at the commits between v3.2.1 and v3.2.2 the only relevant one seems to be 8dd1375.

I tried to partially revert it (the part regarding wxTreeCtrl) and the issue goes away.

Platform and version information

  • wxWidgets version you use: 3.2.2
  • wxWidgets port you use: wxGTK
  • OS and its version: Arch Linux rolling x86_64
  • GTK version: gtk3 1:3.24.36-1
  • Which GDK backend is used: X11/xorg
  • Current theme: any
@vadz vadz added the regression Worked previously, doesn't work any longer label Feb 13, 2023
@vadz
Copy link
Contributor

vadz commented Feb 13, 2023

Thanks for reporting this and sorry for the breakage.

This is due to forgetting to backport 2a13fd2 (Fix drawing of icons for non-root wxTreeCtrl items, 2022-10-27) to 3.2. We're probably going to have to make 3.2.2.1 release with this fix.

vadz added a commit to vadz/wxWidgets that referenced this issue Feb 13, 2023
@vadz
Fix drawing of icons for non-root wxTreeCtrl items
48659cb 
Fix y coordinate value passed to wxDC::DrawBitmap() by restoring the
parentheses accidentally removed in 6dd4e73 (Add wxDrawImageBitmap()
helper and use it in wx{List,Tree}Ctrl, 2022-10-25).

(cherry picked from commit 2a13fd2)

See wxWidgets#23255.
vadz added a commit that referenced this issue Feb 13, 2023
@vadz
Fix drawing of icons for non-root wxTreeCtrl items
ac1df67 
Fix y coordinate value passed to wxDC::DrawBitmap() by restoring the
parentheses accidentally removed in 6dd4e73 (Add wxDrawImageBitmap()
helper and use it in wx{List,Tree}Ctrl, 2022-10-25).

(cherry picked from commit 2a13fd2)

See #23255.
@vadz
Copy link
Contributor

vadz commented Feb 13, 2023

Fixed now in 3.2.2.1.

@vadz vadz closed this as completed Feb 13, 2023
@JoseZancanaro JoseZancanaro mentioned this issue Feb 13, 2023
Closed
vadz added a commit that referenced this issue Feb 13, 2023
@vadz
Fix drawing of icons for non-root wxTreeCtrl items
2922fa0 
Fix y coordinate value passed to wxDC::DrawBitmap() by restoring the
parentheses accidentally removed in 6dd4e73 (Add wxDrawImageBitmap()
helper and use it in wx{List,Tree}Ctrl, 2022-10-25).

(cherry picked from commit 2a13fd2)

See #23255.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression Worked previously, doesn't work any longer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vadz @funnydog