Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGetCursor Implementation #145

Closed
wants to merge 4 commits into from
Closed

wxGetCursor Implementation #145

wants to merge 4 commits into from

Conversation

smasherprog
Copy link

wxGetCursor Implementation Suggestion

updated to latest wxwidgets
Implemented wxGetCursor for msw. Since there is a wxSetCursor, it makes
sense there should be a wxGetCursor
@smasherprog smasherprog changed the title Master wxGetCursor Implementation Dec 7, 2015
@vadz vadz added the work needed Too useful to close, but can't be applied in current state label Dec 7, 2015
@vadz
Copy link
Contributor

vadz commented Dec 7, 2015

Thanks for the PR, but this will break linking under non-MSW platforms, the function should be at least implemented as returning wxNullCursor there, although, unless there is a possibility of getting the current cursor on a platform other than MSW, I'm not sure if it's really useful to have it at all.

Any new function also needs to be documented in interface/wx/utils.h.

@smasherprog
Copy link
Author

I'll add the additional functions for the other platforms. Then, we can go from there.

I added the functions and removed two wxsetcursor functions which should
already be defined in gdicmm.h
@smasherprog
Copy link
Author

Added the additional functions which were required for each platform.
Removed two function declarations which were already defined in in the gdicmn.h

Adding implementations for the various platforms.
Also, in regards to your comment about its usefulness, I would agree that in most cases it isn't useful, so if you want to remove this PR, thats fine. I just saw that there was a missing Getter...

@smasherprog
Copy link
Author

Added other implenetations, but I cannot verify if they are correct because I dont have the platforms. I have completed all that I can for this PR. Let me know if you need additional changes.

@vadz vadz added low priority review needed Waiting for somebody qualified to review it new feature and removed work needed Too useful to close, but can't be applied in current state labels Jan 2, 2016
@vadz
Copy link
Contributor

vadz commented Jun 28, 2017

Did you close it because you found some problem with it or for some other reason?

@vadz vadz added feature and removed new feature labels Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature low priority review needed Waiting for somebody qualified to review it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants