Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vcpkg MSW instructions more MSW-like #1785

Closed
wants to merge 1 commit into from
Closed

Make vcpkg MSW instructions more MSW-like #1785

wants to merge 1 commit into from

Conversation

PBfordev
Copy link
Contributor

@PBfordev PBfordev commented Apr 7, 2020

Make command line instructions for vcpgk more similar to those used
for example for nmake. The MS Windows command line does not use $ as
the command prompt and batch files are more commonly used then Unix
shell scripts.

Make command line instructions for vcpgk more similar to those used
for example for nmake. The MS Windows command line does not use $ as
the command prompt and batch files are more commonly used then Unix
shell scripts.
@vadz
Copy link
Contributor

vadz commented Apr 7, 2020

Thanks, this indeed seems better to me. @NancyLi1013 any objections?

@PBfordev
Copy link
Contributor Author

PBfordev commented Apr 7, 2020

Ah, I did not realize the instructions came from the vcpkg team. Nevertheless, I still believe that these are MSW-specific instructions and the presentation in the whole file should be the same, regardless of the tool. I noticed that sometimes command line instructions in this file do not use any command prompt character. Perhaps it would be better to remove the prompt altogether from everywhere (including MSYS?) as all the commands are short single-line ones.

BTW, I also noticed an embarrassing typo in the 4th word from the end of the commit message: "then" -> "than".

@NancyLi1013
Copy link
Contributor

@PBfordev and @vadz
Thanks for your suggestions and help.
No problem for me.
It might be better to make the instructions more suitable for the specific port.

@vadz vadz closed this in b7edb46 Apr 8, 2020
@PBfordev PBfordev deleted the fix-doc-vpkg branch May 3, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants