Allow suppressing GTK log messages #22424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the code to separate setting of the log callback from the filtering decision. Right now the only existing filter is the one just checking the log level, which is used by GTKSuppressDiagnostics(), but this will allow adding other filters in the upcoming commits.
This will allow suppressing GTK log messages with the specified fixed contents.
These messages are due to an assertion failure deep inside ATK which doesn't indicate any real problem (as failure to get the label of an already destroyed tab is normal and is already handled correctly in the GTK code) and can't be avoided, so suppress them to avoid showing them to the users who can't do anything at all about them anyhow, but can be scared by the "CRITICAL" GTK messages. Closes wxWidgets#22176.
In the future it might be useful to run the code with WXTRACE=gtklog to see if any GTK log messages we're filtering don't need to be filtered any longer.
PBfordev
reviewed
May 12, 2022
|
@paulcor Please let me know if I should wait for your review. Otherwise I'll merge this soon. |
vadz
added a commit
that referenced
this pull request
May 17, 2022
Allow suppressing GTK log messages. See #22424.
|
Merged by the commit above. |
vadz
added a commit
to vadz/wxWidgets
that referenced
this pull request
May 18, 2022
This was recently broken by bffcb88 (Optionally detect not filtered GTK log messages, 2022-05-12), see wxWidgets#22424. Fix it by providing a trivial "do nothing" version of LogFilterByMessage even if we can't implement it -- this seems to be preferable to using preprocessor checks in the code using it. Closes wxWidgets#22434.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #22176 for the motivation.
This will probably be used for other messages in the future.