Queue wxWebViewEdge events #22834
Closed
Queue wxWebViewEdge events #22834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadz
reviewed
Oct 1, 2022
Using HandleWindowEvent() from the WebView2 event callbacks is a common error source when user code does something blocking like RunScript() or ShowModal(). Queue the events to prevent this where possible, in wxEVT_WEBVIEW_NAVIGATING at least warn the developer instead of hanging silently. Closes: wxWidgets#22744, wxWidgets#19075
TcT2k
force-pushed
the
webview_edge_events
branch
from
b25e7e2
to
ba1e82e
Compare
TcT2k
added a commit
to TcT2k/wxWidgets
that referenced
this pull request
Dec 8, 2022
Using HandleWindowEvent() from the WebView2 event callbacks is a common error source when user code does something blocking like RunScript() or ShowModal(). Queue the events to prevent this where possible, in wxEVT_WEBVIEW_NAVIGATING at least warn the developer instead of hanging silently. Closes wxWidgets#22834, wxWidgets#22744, wxWidgets#19075 (cherry picked from commit 0ace989)
vadz
pushed a commit
that referenced
this pull request
Dec 10, 2022
Using HandleWindowEvent() from the WebView2 event callbacks is a common error source when user code does something blocking like RunScript() or ShowModal(). Queue the events to prevent this where possible, in wxEVT_WEBVIEW_NAVIGATING at least warn the developer instead of hanging silently. See #22834, #22744, #19075 Closes #23025. (cherry picked from commit 0ace989)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
HandleWindowEvent()from the WebView2 event callbacks is a common error source when user code does something blocking likeRunScript()orShowModal().Queue the events to prevent this where possible, in
wxEVT_WEBVIEW_NAVIGATINGat least warn the developer instead of hanging silently.Closes: #22744, #19075