Updated wxwin.m4 macro regex to detect x.x.x[...] versions #23402
Conversation
This adds the possibility to detect versions like "3.2.2.1". $ echo "3.2.2.1" | sed -r 's/^([0-9]+)\.([0-9]+)\.([0-9]+)(.*)$/\1/' $ echo "3.2.2.1" | sed -r 's/^([0-9]+)\.([0-9]+)\.([0-9]+)(.*)$/\2/' $ echo "3.2.2.1" | sed -r 's/^([0-9]+)\.([0-9]+)\.([0-9]+)(.*)$/\3/'
|
This seems to be the same as #23289. As mentioned there, it's due to some change to wx-config in Gentoo, but I still don't know why did they change it nor where exactly. But I still suggest submitting your fix to Gentoo developers because it doesn't make sense for wx itself, because our wx-config is never going to output the 4th version component, but they should be willing to take it (if they're not willing to simply revert this change). They also should have no problem with using |
|
Thank you for the precise answer. I completely missed the #23289 PR. Gentoo's devs fixed the problem just minutes ago: Simply put, the fix drops the 4th version component from the release string, so it's never printed by the installed I just installed the Gentoo's I'm closing the PR. Thanks ;) |
|
Great! Thanks for researching it. I'm glad it's all sorted out. |
Hello,
Is it possible to add the possibility to detect wxWidgets versions like
3.2.2.1?There are problems compiling xCHM on Gentoo GNU/Linux with
wxGTK-3.2.2.1installed: https://bugs.gentoo.org/895982The current
wxwin.m4macro fails to detectx.x.x[...]versions:This PR simply adds a capture group to glob the
[...]part inx.x.x[...]:Thanks.