Avoid using destroyed HWND in wxComboPopupWindow
#23406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no safe way to prevent wxWindow from trying to destroy the HWND again if it had been already destroyed, for whatever reason, as UnsubclassWin() asserted if it was called and calling SetHWND(0) before calling it as some (but not all) existing code did, resulted in not removing the association using the old HWND as key. Allow to use DissociateHandle() for safely detaching HWND from the window, without assuming that it is valid.
Don't call SetHWND(0) before calling UnsubclassWin() to prevent it from asserting if the HWND was invalid because this prevented the association with the old HWND from being removed from the global gs_windowHandles and call DissociateHandle() instead. Don't call SetHWND(0) after calling UnsubclassWin() because this was useless, as this function already did this anyhow.
Handle correctly the strange case of the popup window being destroyed by Windows itself, which happened when the AUI floating frame, which was used as the parent of the popup when it was created for a wxComboCtrl inside an AUI pane, was itself destroyed. This resulted in problems because we kept using popup window even though its HWND wasn't valid any longer. Detect when this happens and destroy the popup window too, to force recreating it when/if it's needed again in the future. This also requires keeping wxOwnerDrawnComboBox::m_initChs even after using them, as they will be needed again if we need to recreate the popup. Closes wxWidgets#23399.
vadz
force-pushed
the
combo-danging-popup
branch
from
0a8738c
to
ac21107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destroy
wxComboPopupWindowitself if its HWND got destroyed under it as it happened when it was used inside AUI floating pane.