Test using coreutils catalog in the internat sample #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What used to be called "fileutils" is called "coreutils" since many years now, so use it to demonstrate loading of the standard catalog. Closes wxWidgets#2395
There is no need to suppress wxLog messages from AddCatalog() because it doesn't log any errors even if the catalog is not found, while tracing messages (given only if WXTRACE is set) from it can be useful.
This is more clear than testing for Linux and will allow enabling this code under other systems later (as there doesn't seem to be any real reason not to do it under other Unix systems too). No real changes.
Actually test using the coreutils catalog, as this was broken for many years due to using a wrong catalog name and not adding /usr/share/locale as a search prefix, but went unnoticed. So add a menu item to show translation of a string in this catalog to make testing that this works simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.