Fix crash when dragging in wxAuiNotebook
#24039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix using outdated click position in wxAuiTabCtrl mouse handlers, which resulted in an invalid wxEVT_AUINOTEBOOK_DRAG_MOTION event being generated and a crash while handling it. Ensure that we reset m_clickPt when resetting m_isDragging too so that we don't decide that we're dragging if the mouse enters the window with the left button already pressed after a previous drag. Closes wxWidgets#24027.
Passing an invalid index to this function results in a crash, so ensure this doesn't happen -- at the very least this would have turned the crash fixed by the parent commit into "just" an assert failure.
Ensure that all of them are initialized, including m_clickTab, which didn't seem to be always initialized before. No real changes (as m_clickTab doesn't seem to have been used before it was initialized).
No real changes, just refactor the code to reset all drag-related variables in a single function instead of doing it manually in several places. As this function also resets m_clickTab, which could previosuly remain a dangling pointer, change the code to get its value before calling it.
vadz
added a commit
that referenced
this pull request
Nov 7, 2023
Fix using outdated click position in wxAuiTabCtrl mouse handlers, which resulted in an invalid wxEVT_AUINOTEBOOK_DRAG_MOTION event being generated and a crash while handling it. Ensure that we reset m_clickPt when resetting m_isDragging too so that we don't decide that we're dragging if the mouse enters the window with the left button already pressed after a previous drag. See #24027, #24039. (cherry picked from commit f1a3816)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import commit (which needs to be backported to 3.2) here is the first one, the next ones are just refactorings trying to make the re-occurrence of such bugs less likely.