wx-3.2.x MinGW build tools update #24497
Merged
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just curious: Do we really need to offer MSYS2 binaries? I don't know much about MSYS2 but isn't its purpose to provide the prebuilt libraries and they seem to do that for wxWidgets (before 3.2, they used to have not only the latest 3.0.x version but also the latest 3.1.x release). wxWidgets MSYS2 MinGW packages are available for GCC (both MSVCRT and UCRT builds) as well as CLang as x86, x86_x64 (and aarch64 for clang). |
vadz
reviewed
Apr 24, 2024
| ) else ( | ||
| set COMPBINDIR=G:\MinGW%1-%2\bin | ||
| ) | ||
| if "%1" == "1320" ( |
There was a problem hiding this comment.
FWIW I think you can use else if in BAT files, so this could be done above instead of overwriting the value set in the line 19.
|
Sorry, I've realized that this PR was for 3.2 already, so the question above didn't make sense. I've merged it now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update available compilers version:
/docs/licence.txtwill be added to each created archive file