Cache system fonts in wxOSX #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call CTFontCreateUIFontForLanguage() only once for every CTFontUIFontType value and cache the results, as it is expensive to do it every time wxSystemSettings::GetFont() is called. Closes wxWidgets#19191. This commit is best viewed ignoring whitespace-only changes.
Use "new" (available since 10.5, for most part) values of the enum instead of the deprecated ones, which are still defined, but might not be in the future. No real changes.
csomor
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
thanks for your help, I've verified the normal and small system fonts get cleaned up properly, their ref is at 2 when this module OnExit is called, since there exist local statics in wxWindowMac::DoSetWindowVariant, so only decremented to 1 here, but when the statics get destroyed, ref is down to 0 and data deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #2497.