-
-
Notifications
You must be signed in to change notification settings - Fork 182
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Model Backdrop was "click", now "mousedown" (#304)
* Model Backdrop was "click", now "mousedown" As mentioned in #285 when someone starts a click event inside the modal content area, and then releases it outside, in the backdrop, the modal hides. This is a frustrating issue when selecting text in the modal, as I often do. This only happens in chrome and is also an issue in bootstrap jquery itself. This is the simplest possible fix - replacing @click.self with @mousedown.self. This avoids the weird chrome behaviour. * Changed MessageBox to use mousedown 'should be able to set alert backdrop to true' was sending click event, which unfortunately excludes mousedown. Changed it to send the full event sequence (mousedown,mouseup, click) for maximum generality. * Modal.spec.js - Mousedown changes. Changed backdrop click tests to send the full event sequence (mousedown, mouseup, click) rather than just click.
- Loading branch information
1 parent
d51c06e
commit 1457bf3
Showing
3 changed files
with
7 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters