Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add warnings when important directories are missing #516

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Mar 2, 2024

This closes #515

Screenshot 2024-03-02 at 8 49 34 AM

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 2820cd2
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/65e33cf56208860008522712
😎 Deploy Preview https://deploy-preview-516--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.51%. Comparing base (9cd4e83) to head (2820cd2).

Files Patch % Lines
src/core/utils/building/resolve-config.ts 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
+ Coverage   86.34%   86.51%   +0.17%     
==========================================
  Files         111      111              
  Lines        8778     8798      +20     
  Branches      860      866       +6     
==========================================
+ Hits         7579     7612      +33     
+ Misses       1185     1172      -13     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 self-assigned this Mar 2, 2024
@aklinker1 aklinker1 marked this pull request as ready for review March 2, 2024 14:56
@aklinker1 aklinker1 merged commit 8a6acba into main Mar 2, 2024
17 checks passed
@aklinker1 aklinker1 deleted the dir-warnings branch March 2, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser extension icon disappears after changing srcDir to src
1 participant