Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zip): List .wxt/local_modules overrides relative to the package.json they're added to #526

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Mar 4, 2024

In a monorepo with multiple package.json files, the local modules downloaded by zip.downloadPackages should be relative to the package.json they're added to, not relative to the wxt project's root.

Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 69eb72b
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/65e5f4d5e74f3a0008194447
😎 Deploy Preview https://deploy-preview-526--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 marked this pull request as ready for review March 4, 2024 16:22
@aklinker1 aklinker1 changed the title fix(zip): Resolve .wxt/local_modules relative to the package.json they're added to fix(zip): List .wxt/local_modules overrides relative to the package.json they're added to Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (81b4b62) to head (69eb72b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
+ Coverage   86.59%   86.64%   +0.04%     
==========================================
  Files         111      111              
  Lines        8860     8863       +3     
  Branches      876      877       +1     
==========================================
+ Hits         7672     7679       +7     
+ Misses       1174     1170       -4     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit 23b3980 into main Mar 4, 2024
17 checks passed
@aklinker1 aklinker1 deleted the monorepo-path-fix branch March 4, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant