Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Replace pnpx with pnpm dlx #527

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

lucadalli
Copy link
Contributor

Faced with the error below when trying to use pnpx on my Windows machine.

pnpx : The term 'pnpx' is not recognized as the name of a cmdlet, function, script file, or operable program.

pnpm dlx works fine. pnpm maker Zoltan says pnpx is being deprecated in favor of pnpm dlx.

Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 2aee04c
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/65e8c07e3bacc30008709a21
😎 Deploy Preview https://deploy-preview-527--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 changed the title Replace pnpx with pnpm dlx chore: Replace pnpx with pnpm dlx Mar 6, 2024
@aklinker1
Copy link
Collaborator

@lucadalli Can you replace the other instances of pnpx with pnpm dlx as well?

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.55%. Comparing base (da92449) to head (2aee04c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
- Coverage   86.84%   86.55%   -0.30%     
==========================================
  Files         111      111              
  Lines        8863     8864       +1     
  Branches      879      876       -3     
==========================================
- Hits         7697     7672      -25     
- Misses       1152     1178      +26     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1
Copy link
Collaborator

@lucadalli
Copy link
Contributor Author

lucadalli commented Mar 6, 2024

@aklinker1 Sorry for the incomplete PR, I changed the rest.

Edit: Just an fyi, after switching to node 18.16.1 the original command pnpx wxt@latest init <project-name> works.
If you favor brevity, perhaps we can simply close this.

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I'll keep this change. Thanks for updating the other references!

@aklinker1 aklinker1 changed the title chore: Replace pnpx with pnpm dlx docs: Replace pnpx with pnpm dlx Mar 6, 2024
@aklinker1 aklinker1 merged commit 0d540a6 into wxt-dev:main Mar 6, 2024
17 checks passed
@btea
Copy link
Contributor

btea commented Mar 9, 2024

After this modification, maybe the homepage video can also be updated? @aklinker1
https://wxt.dev/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants