feat(analysis): Open stats.html file automatically
#564
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
==========================================
- Coverage 86.38% 86.32% -0.07%
==========================================
Files 111 111
Lines 8874 8898 +24
Branches 877 877
==========================================
+ Hits 7666 7681 +15
- Misses 1194 1203 +9
Partials 14 14 ☔ View full report in Codecov by Sentry. |
| analysis: flags.analyze ? { enabled: true } : undefined, | ||
| analysis: flags.analyze | ||
| ? { | ||
| enabled: true, | ||
| open: flags.analyzeOpen, | ||
| } | ||
| : undefined, |
There was a problem hiding this comment.
@aklinker1 how hard would it be to respect analysis.open from the config file if --analyzeOpen isn't passed?
There was a problem hiding this comment.
It already behaves that way after this PR. The CLI flags override the relevant options in the config file
I would recommend setting the value in the config file if you always want to open it.
There was a problem hiding this comment.
@aklinker1 this is not how things are behaving for me locally (on 0.17.8) - to clarify, my config looks like this:
analysis: { outputFile: "build/stats.html", open: true }
and when I run wxt build --analyze, analysis.outputFile is respected, but analysis.open is not.
FYI, I don't specify analysis.enable in my config as I only want to do this in a specific NPM script.
Could it be that the override logic isn't taking into account that flags.analyzeOpen is undefined, but analysis.open still exists if flags.analyze does (like how "prop" in { prop: undefined } is true)?
There was a problem hiding this comment.
Interesting, let me take a look. You're setup is what I intended, so I'll fix it
There was a problem hiding this comment.
Yup, the undefined was overriding the true:
userConfigcomes from the wxt.config.ts file,inlineConfigis the CLI flags, and merged is the output of merging them together.
Caused by the spread operator, replaced with defu and it's working: #567
This closes #561.
Either set
analysis.openinwxt.config.tsor runwxt build --analyze --analyze-open.Todo